Changeset 746 for trunk/lib/Currency.inc.php

Timestamp:

May 31, 2021 1:51:18 AM (3 years ago)

Author:

anonymous

Message:

Add brackets to avoid ambiguity in return value

File:

• trunk/lib/Currency.inc.php (modified) (2 diffs)

trunk/lib/Currency.inc.php

@@ -123 +123 @@
     public function getValue($amount, $base, $target)
     {
-        if (false !== $rate = $this->getRate($base, $target)) {
+        if (false !== ($rate = $this->getRate($base, $target))) {
             return abs($rate * $amount);
         } else {
@@ -231 +231 @@
             // Fetch XML from ECB <http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml>
             $api_url = 'http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml';
-            if (false === $sXML = file_get_contents($api_url)) {
+            if (false === ($sXML = file_get_contents($api_url))) {
                 $app->logMsg(sprintf('Failed to load ECB XML data from: %s', $api_url), LOG_WARNING, __FILE__, __LINE__);
                 return false;
             }
-            if (false === $oXML = simplexml_load_string($sXML)) {
+            if (false === ($oXML = simplexml_load_string($sXML))) {
                 $app->logMsg(sprintf('Failed to decode ECB XML data: %s', truncate($sXML, 200, 'end')), LOG_WARNING, __FILE__, __LINE__);
                 return false;