Changeset 550 for trunk/lib/Currency.inc.php

Timestamp:

Nov 24, 2015 5:38:54 PM (8 years ago)

Author:

anonymous

Message:

Escaped quotes from email from names.
Changed logMsg string truncation method and added version to email log msg.
Better variable testing in carry queries.
Spelling errors.
Added runtime cache to Currency.
Added logging to form validation.
More robust form validation.
Added json serialization methond to Version.

File:

• trunk/lib/Currency.inc.php (modified) (5 diffs)

trunk/lib/Currency.inc.php

@@ -40 +40 @@
 class Currency
 {
-
     // Configuration parameters for this object.
     protected $_params = array(
@@ -49 +48 @@
         'api_key' => '', // Used only by xurrency API.
     );
+
+    // Static runtime cache of values.
+    private static $rates = array();
 
     /**
@@ -143 +145 @@
         $app =& App::getInstance();
 
+        // If we've looked-up this rate during this run, return it from the runtime cache.
+        $rate_key = sprintf('%s-to-%s', $base, $target);
+        if (isset(self::$rates[$rate_key])) {
+            $app->logMsg(sprintf('Found %s in runtime cache: %s', $rate_key, self::$rates[$rate_key]), LOG_DEBUG, __FILE__, __LINE__);
+            return self::$rates[$rate_key];
+        }
+
         $cache_file_path = sprintf('%s/%s-to-%s', $this->getParam('cache_dir'), $base, $target);
+        if (!is_dir(dirname($cache_file_path))) {
+            mkdir(dirname($cache_file_path));
+        }
         $cache_file_mtime = @filemtime($cache_file_path);
         if (!$this->getParam('cache_result') || !$cache_file_mtime || $cache_file_mtime < time() - $this->getParam('cache_age')) {
@@ -172 +184 @@
         }
         $app->logMsg(sprintf('Found currency exchange rate: %s-to-%s = %s', $base, $target, $value), LOG_DEBUG, __FILE__, __LINE__);
+
+        // Store the value in the runtime cache.
+        self::$rates[$rate_key] = trim($value);
+
         return trim($value);
     }
@@ -239 +255 @@
                 return (float) $aCurrencies[$parameters['base']][$parameters['target']];
             } else {
-                $app->logMsg(sprintf('API %s does not have base %s or target %s', $this->getParam('api'), $parameters['base'], $parameters['target']), LOG_WARNING, __FILE__, __LINE__);
+                $app->logMsg(sprintf('API %s does not have base %s or target %s', $this->getParam('api'), $parameters['base'], $parameters['target']), LOG_ALERT, __FILE__, __LINE__);
                 return false;
             }
 
         default :
-            trigger_error('Unknown API: ' . $this->getParam('api'), E_USER_ERROR);
-            die;
-            break;
+            $app->logMsg(sprintf('Unknown currency API: %s', $this->getParam('api')), LOG_ERR, __FILE__, __LINE__);
+            return false;
         }
     }