Changeset 815 for trunk/lib/App.inc.php

Timestamp:

May 5, 2024 8:41:57 PM (13 days ago)

Author:

anonymous

Message:

Minor fixes

File:

• trunk/lib/App.inc.php (modified) (2 diffs)

trunk/lib/App.inc.php

@@ -1958 +1958 @@
         $format = $format ?: $this->getParam('lc_date_format');
         if ($format && mb_strpos($format, '%') !== false) {
-            // The date format is localized for strftime(). It only accepts a timestamp, which are always in UTC, so we hack this by offering the date from the user's timezone in a format without a TZ specified, which is used to a make a timestamp for strftime (we can't use DaateTime->format('U') because that would convert the date back to UTC).
-            return strftime($format, strtotime($dt->format('Y-m-d H:i:s')));
+            // The date format is localized for strftime(). It only accepts a timestamp, which are always in UTC, so we hack this by offering the date from the user's timezone in a format without a TZ specified, which is used to a make a timestamp for strftime (we can't use DateTime->format('U') because that would convert the date back to UTC).
+            // FIXME: The strftime() function is deprecated as of PHP 8.1.
+            // Consider replacing strftime() with a non-deprecated alternative like DateTime::format() or IntlDateFormatter for locale-specific formatting.
+            return @strftime($format, strtotime($dt->format('Y-m-d H:i:s')));
         } else {
             // Otherwise use a regular date format.
@@ -1980 +1982 @@
     {
         try {
-            // Create a DateTime object and conver the timezone from server to user.
+            // Create a DateTime object and convert the timezone from server to user.
             $dt = $this->convertTZ($datetime, $this->getParam('user_timezone'), $this->getParam('php_timezone'));
         } catch (Exception $e) {