Changeset 763 for trunk/lib/App.inc.php

Timestamp:

Feb 24, 2022 10:05:48 PM (2 years ago)

Author:

anonymous

Message:

Include boomerang in hidden input on login form so the user will be redirected if the revisit the login form after session is garbage collected. Add escape values used in html attributes.

File:

• trunk/lib/App.inc.php (modified) (4 diffs)

trunk/lib/App.inc.php

@@ -1335 +1335 @@
                     foreach ($val as $subval) {
                         if ('' != $key && '' != $subval) {
-                            $out .= sprintf('<input type="hidden" name="%s[]" value="%s" />', $key, $subval);
+                            $out .= sprintf('<input type="hidden" name="%s[]" value="%s" />', oTxt($key), oTxt($subval));
                         }
                     }
                 } else if ('' != $key && '' != $val) {
-                    $out .= sprintf('<input type="hidden" name="%s" value="%s" />', $key, $val);
+                    $out .= sprintf('<input type="hidden" name="%s" value="%s" />', oTxt($key), oTxt($val));
                 }
             }
@@ -1355 +1355 @@
         && $this->getParam('session_use_trans_sid')
         ) {
-            $out .= sprintf('<input type="hidden" name="%s" value="%s" />', session_name(), session_id());
+            $out .= sprintf('<input type="hidden" name="%s" value="%s" />', oTxt(session_name()), oTxt(session_id()));
         }
 
@@ -1361 +1361 @@
         // This token can be validated upon form submission with $app->verifyCSRFToken() or $app->requireValidCSRFToken()
         if ($this->getParam('csrf_token_enabled') && $include_csrf_token) {
-            $out .= sprintf('<input type="hidden" name="%s" value="%s" />', $this->getParam('csrf_token_name'), $this->getCSRFToken());
+            $out .= sprintf('<input type="hidden" name="%s" value="%s" />', oTxt($this->getParam('csrf_token_name')), oTxt($this->getCSRFToken()));
         }
 
@@ -1530 +1530 @@
         } else {
             // Fallback: die using meta refresh instead.
-            printf('<meta http-equiv="refresh" content="0;url=%s" />', $url);
+            printf('<meta http-equiv="refresh" content="0;url=%s" />', oTxt($url));
             $this->logMsg(sprintf('dieURL (refresh): %s; headers already sent (output started in %s : %s)', $url, $h_file, $h_line), LOG_NOTICE, __FILE__, __LINE__);
         }