Changeset 478 for trunk/lib/App.inc.php

Timestamp:

May 3, 2014 9:13:05 PM (10 years ago)

Author:

anonymous

Message:

Using array_key_exists() instead of isset() where null may be a used value. Added params to Prefs constructor. Include setDefault functionality for cookie storage types. Finished cookie storagetype of Prefs.

File:

• trunk/lib/App.inc.php (modified) (2 diffs)

trunk/lib/App.inc.php

@@ -230 +230 @@
         if ($param === null) {
             return $this->_params;
-        } else if (isset($this->_params[$param])) {
+        } else if (array_key_exists($param, $this->_params)) {
             return $this->_params[$param];
         } else {
@@ -802 +802 @@
         }
         foreach ($query_key as $k) {
-            if (isset($this->_carry_queries[$k])) {
+            if (array_key_exists($k, $this->_carry_queries)) {
                 // Remove the value of the specified query argument from the _carry_queries array.
                 $this->logMsg(sprintf('Dropping carried query: %s => %s', $k, $this->_carry_queries[$k]), LOG_DEBUG, __FILE__, __LINE__);
                 unset($this->_carry_queries[$k]);
             }
-            if ($unset && isset($_REQUEST[$k])) {
+            if ($unset && array_key_exists($k, $_REQUEST)) {
                 unset($_REQUEST[$k], $_GET[$k], $_POST[$k], $_COOKIE[$k]);
             }