Changeset 159 for trunk/lib/Prefs.inc.php

Timestamp:

Jun 11, 2006 5:41:23 AM (18 years ago)

Author:

scdev

Message:

${1}

File:

• trunk/lib/Prefs.inc.php (modified) (3 diffs)

trunk/lib/Prefs.inc.php

@@ -180 +180 @@
         }
         
+        // Set a persistent perference if...
+        // - there isn't a default.
+        // - the new value is different than the default
+        // - there is a previously existing pesistent key.
         if (!isset($_SESSION['_prefs'][$this->_ns]['defaults'][$key]) || $_SESSION['_prefs'][$this->_ns]['defaults'][$key] != $val || isset($_SESSION['_prefs'][$this->_ns]['persistent'][$key])) {
             $_SESSION['_prefs'][$this->_ns]['persistent'][$key] = $val;            
+            $app->logMsg(sprintf('Setting preference %s to %s', $key, $val), LOG_DEBUG, __FILE__, __LINE__);
+        } else {
+            $app->logMsg(sprintf('not setting %s to %s', $key, $val), LOG_DEBUG, __FILE__, __LINE__);
         }
     }
@@ -347 +354 @@
         $this->initDB();
 
-        if (isset($_SESSION['_prefs'][$this->_ns]['persistent']) && is_array($_SESSION['_prefs'][$this->_ns]['persistent'])) {
+        if (isset($_SESSION['_prefs'][$this->_ns]['persistent']) && is_array($_SESSION['_prefs'][$this->_ns]['persistent']) && !empty($_SESSION['_prefs'][$this->_ns]['persistent'])) {
             // Delete old prefs from database.
             $db->query("
@@ -365 +372 @@
                 );
             }
+            // TODO: after MySQL 5.0.23 is released this query could benefit from INSERT DELAYED.
             $db->query("
-                INSERT LOW_PRIORITY INTO " . $db->escapeString($this->getParam('db_table')) . " 
+                INSERT INTO " . $db->escapeString($this->getParam('db_table')) . " 
                 (user_id, pref_namespace, pref_key, pref_value)
                 VALUES " . join(', ', $insert_values) . "