Custom Query (6 matches)

We need to test if ACL.inc.php has a problem with this:

ACL should warn if you add or edit an multiply-grouped ARO in such a way that the ARO's access to an ACO would be ambiguous. Is it up to the user to resolve the conflict?

• EDITORS > EDIT = allow
• INTERNS > EDIT = deny

If user23 is in both groups, which has prescience?

I would like to bring our codebase framework up-to-date with php 5.3+ standards, specifically with class definitions, public/private method statements, magic functions, etc. Currently it works fine under php5, but I'd like to take the final step so it runs exceptionally on php5 and not at all on php4.

Goals

Identify new features introduced between php 5.0 and 5.3 that will:

• bring tangible benefit for our use (e.g., anything that brings a performance benefit, or improves error handling)
• make the codebase more future proof (e.g., migrating the current mysql_* function calls (which are to be depreciated in v6) with something else, or implement the required aspects of the new Object Model).

The code should run with no errors using 'E_STRICT' and 'E_ALL' error_reporting, and pass all the unit tests (run via codebase/test/run_tests.sh).

Requirements

1. Backwards compatibility with existing sites that use the codebase. This will make implementation of PDO slightly more tricky, but is possible.
2. Don't make modifications that require extensive testing. Currently the codebase is mature and very stable. I hope the changes we make won't' make it unstable.
3. We only implement what we can do in 10-15 hours.

Beau, I'm opening this ticket until we've worked out all the glitches in PEdit.

Here's one: In PEdit.inc.php, this...

id="sc-pedit-<?php echo $name; ?>"

...should be changed to...

id="sc-pedit-field-<?php echo $name; ?>"

...or something similar to prevent the case where $name is "form" or some other conflicting title. Is this id="" used anywhere else?