Changeset 791

Timestamp:

Apr 7, 2023 11:13:53 PM (13 months ago)

Author:

anonymous

Message:

Log authentication failures because of 'multiple users with username'

File:

• trunk/lib/Auth_SQL.inc.php (modified) (1 diff)

trunk/lib/Auth_SQL.inc.php

@@ -429 +429 @@
             WHERE " . $this->_params['db_username_column'] . " = '" . $db->escapeString($username) . "'
         ");
-        if (mysql_num_rows($qid) !== 1 || !$user_data = mysql_fetch_assoc($qid)) {
-            $app->logMsg(sprintf('Username %s not found for authentication', $username), LOG_NOTICE, __FILE__, __LINE__);
+        if (mysql_num_rows($qid) === 0 || !$user_data = mysql_fetch_assoc($qid)) {
+            $app->logMsg(sprintf('Authentication failed; username %s not found', $username), LOG_NOTICE, __FILE__, __LINE__);
+            return false;
+        }
+        if (mysql_num_rows($qid) !== 1) {
+            $app->logMsg(sprintf('Authentication failed; multiple users with username "%s"', $username), LOG_WARNING, __FILE__, __LINE__);
             return false;
         }