Changeset 775 for trunk

Timestamp:

Oct 29, 2022 4:33:45 AM (18 months ago)

Author:

anonymous

Message:

Minor improvements

Location:

trunk/lib

Files:

• App.inc.php (modified) (1 diff)
• Auth_SQL.inc.php (modified) (3 diffs)
• ImageThumb.inc.php (modified) (1 diff)

trunk/lib/App.inc.php

@@ -1516 +1516 @@
         if (!$this->running) {
             $this->logMsg(sprintf('Canceled %s, application not running.', __METHOD__), LOG_NOTICE, __FILE__, __LINE__);
-            return false;
+            $this->stop();
+            die;
         }
 

trunk/lib/Auth_SQL.inc.php

@@ -429 +429 @@
             WHERE " . $this->_params['db_username_column'] . " = '" . $db->escapeString($username) . "'
         ");
-        if (!$user_data = mysql_fetch_assoc($qid)) {
+        if (mysql_num_rows($qid) !== 1 || !$user_data = mysql_fetch_assoc($qid)) {
             $app->logMsg(sprintf('Username %s not found for authentication', $username), LOG_NOTICE, __FILE__, __LINE__);
             return false;
@@ -601 +601 @@
 
         // Session created! We're logged-in!
+        $app->logMsg(sprintf('“%s” auth session created for user_id %s (%s): %s=%s', $this->_ns, $this->get('user_id'), $this->get('username'), session_name(), session_id()), LOG_DEBUG, __FILE__, __LINE__);
         return true;
     }
@@ -612 +613 @@
      *  - remote address is the same as the login remote address
      *
-     * TODO: implement persisten sessions as per https://paragonie.com/blog/2015/04/secure-authentication-php-with-long-term-persistence
+     * TODO: implement persistent sessions as per https://paragonie.com/blog/2015/04/secure-authentication-php-with-long-term-persistence
      *
      * @access public

trunk/lib/ImageThumb.inc.php

@@ -297 +297 @@
             }
             $this->_raiseMsg(sprintf(_("Resized %s images."), sizeof($files)), MSG_SUCCESS, __FILE__, __LINE__);
-            $this->_raiseMsg(sprintf(_("Resized %s images."), sizeof($files)), MSG_SUCCESS, __FILE__, __LINE__);
             return 0 === $return_val;
         } else {