Changeset 770 for trunk/lib

Timestamp:

Jun 11, 2022 11:15:06 PM (2 years ago)

Author:

anonymous

Message:

Minor fixes

Location:

trunk/lib

Files:

• Email.inc.php (modified) (2 diffs)
• Utilities.inc.php (modified) (1 diff)
• Validator.inc.php (modified) (1 diff)

trunk/lib/Email.inc.php

@@ -372 +372 @@
         foreach ($headers as $key => $val) {
             // Validate key and values.
-            if (!strlen($val)) {
+            if (!isset($val) || !strlen($val)) {
                 $app->logMsg(sprintf('Empty email header provided: %s', $key), LOG_NOTICE, __FILE__, __LINE__);
                 continue;
@@ -447 +447 @@
         // Ensure message was successfully accepted for delivery.
         if ($ret) {
-            $app->logMsg(sprintf('Email successfully sent to %s', $final_to), LOG_INFO, __FILE__, __LINE__);
+            $app->logMsg(sprintf('Email successfully sent to %s: %s', $final_to, $this->_params['subject']), LOG_INFO, __FILE__, __LINE__);
             return true;
         } else {

trunk/lib/Utilities.inc.php

@@ -1373 +1373 @@
     } else {
         $app =& App::getInstance();
-        $app->logMsg(sprintf('Failed signature (%s should be %s)', $signed_val, addSignature($val, $salt, $length)), LOG_DEBUG, __FILE__, __LINE__);
+        // A signature mismatch might occur if the signing_key is not the same across all environments, apache, cli, etc.
+        $app->logMsg(sprintf('Failed signature (%s should be %s).', $signed_val, addSignature($val, $salt, $length)), LOG_DEBUG, __FILE__, __LINE__);
         return false;
     }

trunk/lib/Validator.inc.php

@@ -348 +348 @@
         }
 
-        if ($strict && getmxrr('checkdnsrr', $hosts_notused) && !getmxrr($domain)) {
+        if ($strict && function_exists('getmxrr') && !getmxrr($domain, $hosts_notused)) {
             // Strict tests: check if MX record exists.
             $app->logMsg(sprintf('%s (line %s) failed: %s', __METHOD__, __LINE__, getDump($val)), $type, $file, $line);