Changeset 763 for trunk/services

Timestamp:

Feb 24, 2022 10:05:48 PM (2 years ago)

Author:

anonymous

Message:

Include boomerang in hidden input on login form so the user will be redirected if the revisit the login form after session is garbage collected. Add escape values used in html attributes.

Location:

trunk/services

Files:

• logs.php (modified) (1 diff)
• password.php (modified) (1 diff)
• reset_password.php (modified) (1 diff)
• templates/login_form.ihtml (modified) (1 diff)

trunk/services/logs.php

@@ -70 +70 @@
 
 // Titles and navigation header.
-$nav->add(sprintf(_("Viewing <em>%s</em>"), $tmp_prefs->get('log_file')), '/admin/logs.php');
+$nav->add(sprintf(_("Viewing <em>%s</em>"), oTxt($tmp_prefs->get('log_file'))), '/admin/logs.php');
 $nav->set('id', 'logs');
 

trunk/services/password.php

@@ -41 +41 @@
 
 // Titles and navigation header.
-$nav->add(sprintf(_("Change password for <em>%s</em>"), $auth->get('username')));
+$nav->add(sprintf(_("Change password for <em>%s</em>"), oTxt($auth->get('username'))));
 $nav->set('id', 'password');
 

trunk/services/reset_password.php

@@ -69 +69 @@
             $app->dieURL($auth->getParam('login_url'));
         } else {
-            $app->raiseMsg(sprintf(_("There was a problem resetting the password for <em>%s</em>. Please contact us if you need assistance."), getFormData('username')), MSG_WARNING, __FILE__, __LINE__);
+            $app->raiseMsg(sprintf(_("There was a problem resetting the password for <em>%s</em>. Please contact us if you need assistance."), oTxt(getFormData('username'))), MSG_WARNING, __FILE__, __LINE__);
             $app->logMsg(sprintf('Password reset for %s failed.', getFormData('username')), LOG_NOTICE, __FILE__, __LINE__);
             $frm = array('username' => getFormData('username'));

trunk/services/templates/login_form.ihtml

@@ -3 +3 @@
 ?>
 <form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" class="sc-form"<?php echo $autocomplete; ?>>
-<?php $app->printHiddenSession() ?>
+<?php $app->printHiddenSession(['boomerang']) ?>
 <table>
     <tr class="sc-form-row">