Changeset 692 for trunk/lib

Timestamp:

Jun 22, 2019 3:01:53 AM (5 years ago)

Author:

anonymous

Message:

misc

Location:

trunk/lib

Files:

• App.inc.php (modified) (4 diffs)
• Auth_SQL.inc.php (modified) (1 diff)

trunk/lib/App.inc.php

@@ -114 +114 @@
         'date_format' => 'd M Y',
         'time_format' => 'h:i:s A',
+        'lc_date_format' => '%e %b %Y', // Localized date for strftime() https://www.php.net/manual/en/function.strftime.php
+        'lc_time_format' => '%k:%M', // Localized time for strftime() https://www.php.net/manual/en/function.strftime.php
         'sql_date_format' => '%e %b %Y',
         'sql_time_format' => '%k:%i',
@@ -386 +388 @@
         // If external request was HTTPS but internal request is HTTP, set $_SERVER['HTTPS']='on', which is used by the application to determine that TLS features should be enabled.
         if (strtolower(getenv('HTTP_X_FORWARDED_PROTO')) == 'https' && strtolower(getenv('REQUEST_SCHEME')) == 'http') {
+            $this->logMsg(sprintf('Detected HTTPS via X-Forwarded-Proto; setting HTTPS=on', null), LOG_DEBUG, __FILE__, __LINE__);
             putenv('HTTPS=on'); // Available via getenv(
)
             isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] = 'on'; // Available via $_SERVER[
]
@@ -1444 +1447 @@
         }
 
-        if (!$url) {
+        if ('' == $url) {
             // If URL is not specified, use the redirect_home_url.
             $url = $this->getParam('redirect_home_url');
@@ -1462 +1465 @@
 
         // End application.
-        // Recommended, although I'm not sure it's necessary: http://cn2.php.net/session_write_close
+        // Recommended, although I'm not sure it's necessary: https://www.php.net/session_write_close
         $this->stop();
         die;

trunk/lib/Auth_SQL.inc.php

@@ -433 +433 @@
             return false;
         }
+
+        // TODO: log all auth attempts to db_login_table, not just successful ones. Then, rate-limit login attempts.
 
         // Check given password against hashed DB password.