Changeset 359

Timestamp:

Sep 26, 2009 8:38:25 PM (15 years ago)

Author:

quinn

Message:

Modified logMsg throttle so as not to create thousands of lock files.

File:

• trunk/lib/App.inc.php (modified) (2 diffs)

trunk/lib/App.inc.php

@@ -555 +555 @@
         }
 
-        // Create tmp files so that we don't email and sms redundantly.
+        // Use "lock" files to prevent sending email and sms notices ad infinitum.
         $site_hash = md5($_SERVER['SCRIPT_NAME']);
         $temp_dir = $this->getParam('tmp_dir') . "/codebase_msgs_$site_hash/";
-        $temp_file = $temp_dir . $msg_id;
+        $temp_file = $temp_dir . md5($file . $line); // Just use the file and line for the msg_id to limit the number of possible messages.
         if (!is_dir($temp_dir)) {
             mkdir($temp_dir);
@@ -1014 +1014 @@
         // A redirection will never happen immediately after setting the boomerangURL.
         // Set the time so ensure this doesn't happen. See $app->validBoomerangURL for more.
+        /// FIXME: Why isn't the time set here under setBoomerangURL() and only under dieBoomerangURL()?
 
         if ('' != $url && is_string($url)) {