Changeset 341 for trunk/lib

Timestamp:

Feb 5, 2009 10:30:54 PM (15 years ago)

Author:

dan

Message:

Added throttling to the logMsg function for SMS and EMAIL alearts. No need to send the same error to a human multiple times per minute. log_mutiple_timeout is used to cotrolhow long to time a message out for. Default is 60 seconds. So multiple emails and sms's will not be sent if the same msg happens more offten than every minute.

File:

• trunk/lib/App.inc.php (modified) (4 diffs)

trunk/lib/App.inc.php

@@ -106 +106 @@
         'log_filename' => 'app_log',
 
+        //Don't email or sms duplicate messages that happen more often than this value in sceonds
+        'log_multiple_timeout' => 60,
+
         // Logging priority can be any of the following, or false to deactivate:
         // LOG_EMERG     system is unusable
@@ -116 +119 @@
         // LOG_DEBUG     debug-level message
         'log_file_priority' => LOG_INFO,
-        'log_email_priority' => false,
+        'log_email_priority' => LOG_INFO,
         'log_sms_priority' => false,
         'log_screen_priority' => false,
 
         // Email address to receive log event emails.
-        'log_to_email_address' => null,
+        'log_to_email_address' => 'dan@strangecode.com',
 
         // SMS Email address to receive log event SMS messages.
@@ -548 +551 @@
             $previous_events[$msg_id] = 1;
         }
+
+        // Create tmp files so that we don't email and sms redundantly.
+        $site_hash = md5(SITE_BASE);
+        $temp_dir = "/tmp/codebase_msgs_$site_hash/";
+        $temp_file = $temp_dir . $msg_id;
+        if (!is_dir($temp_dir)) {
+            mkdir($temp_dir);
+        }
+        $send_notifications = true;
+        if (is_file($temp_file)) {
+            $msg_last_sent = filectime($temp_file);
+            //Has this message been sent more recently than the timeout?
+            if ((time() - $msg_last_sent) < $this->getParam('log_multiple_timeout')) {
+                //this message was alreay sent recently
+                $send_notifications = false;
+            } else {
+                //timeout has expired go ahead and send notifications again
+                unlink($temp_file);
+            }
+        } else {
+            touch($temp_file);
+        }
+        
         
         // Data to be stored for a log event.
@@ -566 +592 @@
         }
 
-        // EMAIL ACTION
-        if ($this->getParam('log_email_priority') && $priority <= $this->getParam('log_email_priority')) {
-            $subject = sprintf('[%s %s] %s', getenv('HTTP_HOST'), $event['type'], $message);
-            $email_msg = sprintf("A %s log event occured on %s\n\n", $event['type'], getenv('HTTP_HOST'));
-            $headers = "From: codebase@strangecode.com";
-            foreach ($event as $k=>$v) {
-                $email_msg .= sprintf("%-11s%s\n", $k, $v);
-            }
-            mb_send_mail($this->getParam('log_to_email_address'), $subject, $email_msg, $headers, '-f codebase@strangecode.com');
-        }
-
-        // SMS ACTION
-        if ($this->getParam('log_sms_priority') && $priority <= $this->getParam('log_sms_priority')) {
-            $subject = sprintf('[%s %s]', getenv('HTTP_HOST'), $priority);
-            $sms_msg = sprintf('%s [%s:%s]', mb_substr($event['message'], 0, 64), basename($file), $line);
-            $headers = "From: codebase@strangecode.com";
-            mb_send_mail($this->getParam('log_to_sms_address'), $subject, $sms_msg, $headers, '-f codebase@strangecode.com');
-        }
-
+        // NOTIFY SOMEONE
+        if ($send_notifications) {
+
+            // EMAIL ACTION
+            if ($this->getParam('log_email_priority') && $priority <= $this->getParam('log_email_priority')) {
+                $subject = sprintf('[%s %s] %s', getenv('HTTP_HOST'), $event['type'], $message);
+                $email_msg = sprintf("A %s log event occured on %s\n\n", $event['type'], getenv('HTTP_HOST'));
+                $headers = "From: codebase@strangecode.com";
+                foreach ($event as $k=>$v) {
+                    $email_msg .= sprintf("%-11s%s\n", $k, $v);
+                }
+                mb_send_mail($this->getParam('log_to_email_address'), $subject, $email_msg, $headers, '-f codebase@strangecode.com');
+            }
+    
+            // SMS ACTION
+            if ($this->getParam('log_sms_priority') && $priority <= $this->getParam('log_sms_priority')) {
+                $subject = sprintf('[%s %s]', getenv('HTTP_HOST'), $priority);
+                $sms_msg = sprintf('%s [%s:%s]', mb_substr($event['message'], 0, 64), basename($file), $line);
+                $headers = "From: codebase@strangecode.com";
+                mb_send_mail($this->getParam('log_to_sms_address'), $subject, $sms_msg, $headers, '-f codebase@strangecode.com');
+            }
+
+        }
+    
         // SCREEN ACTION
         if ($this->getParam('log_screen_priority') && $priority <= $this->getParam('log_screen_priority')) {