Changeset 185 for branches/1.1dev


Ignore:
Timestamp:
Jun 24, 2006 11:02:54 PM (18 years ago)
Author:
scdev
Message:

Q - added oTxt() around all printed PHP_SELFs to avoid XSS attack. See: ​http://blog.phpdoc.info/archives/13-XSS-Woes.html

Location:
branches/1.1dev
Files:
12 edited

Legend:

Unmodified
Added
Removed

  • branches/1.1dev/bin/module_maker/list_template.cli.php

    r109 r185  
    104104
    105105<\x3fphp include 'form_error_header.ihtml'; \x3f>
    106 <form action="<\x3fphp echo \$_SERVER['PHP_SELF']; \x3f>" method="post">
     106<form action="<\x3fphp echo oTxt(\$_SERVER['PHP_SELF']); \x3f>" method="post">
    107107<\x3fphp printHiddenSession(false); \x3f>
    108108

  • branches/1.1dev/bin/module_maker/module.cli.php

    r124 r185  
    248248$search['admin_form_tag_init'] = '/%ADMIN_FORM_TAG_INIT%/';
    249249if ($multipart_form_required) {
    250     $replace['admin_form_tag_init'] = "<form enctype=\"multipart/form-data\" method=\"post\" action=\"<\x3fphp echo \$_SERVER['PHP_SELF']; \x3f>\">\n<input type=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"12000000\">";
    251 } else {
    252     $replace['admin_form_tag_init'] = "<form method=\"post\" action=\"<\x3fphp echo \$_SERVER['PHP_SELF']; \x3f>\">";
     250    $replace['admin_form_tag_init'] = "<form enctype=\"multipart/form-data\" method=\"post\" action=\"<\x3fphp echo oTxt(\$_SERVER['PHP_SELF']); \x3f>\">\n<input type=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"12000000\">";
     251} else {
     252    $replace['admin_form_tag_init'] = "<form method=\"post\" action=\"<\x3fphp echo oTxt(\$_SERVER['PHP_SELF']); \x3f>\">";
    253253}
    254254

  • branches/1.1dev/bin/module_maker/skel/adm_list.ihtml

    r109 r185  
    33
    44<div id="commandbox">
    5     <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="get">
     5    <form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="get">
    66        <?php printHiddenSession(false); ?>
    77        <span class="nowrap commandtext"><a href="<?php echo ohref($_SERVER['PHP_SELF'] . '?op=add'); ?>"><?php echo _("Add %ITEM_TITLE%"); ?></a></span>
    … …  
    1818<?php include 'adm_list_info.ihtml'; ?>
    1919
    20 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     20<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    2121    <?php printHiddenSession(false); ?>
    2222    <table class="list">

  • branches/1.1dev/lib/PEdit.inc.php

    r1 r185  
    273273        }
    274274        ?>
    275         <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     275        <form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    276276        <input type="hidden" name="filename" value="<?php echo $this->_filename; ?>" />
    277277        <input type="hidden" name="file_hash" value="<?php echo md5('frog_guts' . $this->_filename); ?>" />

  • branches/1.1dev/templates/adm_admin_form.ihtml

    r1 r185  
    11<?php include 'form_error_header.ihtml'; ?>
    22
    3 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     3<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    44<?php printHiddenSession(); ?>
    55<input type="hidden" name="op" value="<?php echo $frm['new_op']; ?>">

  • branches/1.1dev/templates/adm_admin_list.ihtml

    r30 r185  
    11
    22<?php include 'form_error_header.ihtml'; ?>
    3 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     3<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    44<?php $carry_queries = array('search_query', 'filter_admin_priv'); ?>
    55<?php printHiddenSession(false); ?>

  • branches/1.1dev/templates/adm_log_list.ihtml

    r30 r185  
    11
    22<?php include 'form_error_header.ihtml'; ?>
    3 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     3<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    44<?php printHiddenSession(false); ?>
    55

  • branches/1.1dev/templates/adm_login_form.ihtml

    r1 r185  
    1 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     1<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    22<?php printHiddenSession() ?>
    33<table border="0" cellspacing="0" cellpadding="4">

  • branches/1.1dev/templates/adm_record_lock.ihtml

    r1 r185  
    1 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     1<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    22<?php printHiddenSession() ?>
    33<input type="hidden" name="lock_id" value="<?php echo $lock->getID(); ?>" />

  • branches/1.1dev/templates/adm_record_version_list.ihtml

    r1 r185  
    1 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     1<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    22<?php printHiddenSession() ?>
    33<input type="submit" class="formsubmitbutton" name="op" value="<?php echo _("Cancel"); ?>">

  • branches/1.1dev/templates/login_form.ihtml

    r1 r185  
    1 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     1<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    22<?php printHiddenSession() ?>
    33<table border="0" cellspacing="0" cellpadding="4">

  • branches/1.1dev/templates/passwd.ihtml

    r1 r185  
    11<?php include 'form_error_header.ihtml'; ?>
    22
    3 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     3<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    44<?php printHiddenSession() ?>
    55<input type="hidden" name="op" value="update_password">
Note: See TracChangeset for help on using the changeset viewer.