Changeset 185


Ignore:
Timestamp:
Jun 24, 2006 11:02:54 PM (18 years ago)
Author:
scdev
Message:

Q - added oTxt() around all printed PHP_SELFs to avoid XSS attack. See: ​http://blog.phpdoc.info/archives/13-XSS-Woes.html

Files:
37 edited

Legend:

Unmodified
Added
Removed

  • branches/1.1dev/bin/module_maker/list_template.cli.php

    r109 r185  
    104104
    105105<\x3fphp include 'form_error_header.ihtml'; \x3f>
    106 <form action="<\x3fphp echo \$_SERVER['PHP_SELF']; \x3f>" method="post">
     106<form action="<\x3fphp echo oTxt(\$_SERVER['PHP_SELF']); \x3f>" method="post">
    107107<\x3fphp printHiddenSession(false); \x3f>
    108108

  • branches/1.1dev/bin/module_maker/module.cli.php

    r124 r185  
    248248$search['admin_form_tag_init'] = '/%ADMIN_FORM_TAG_INIT%/';
    249249if ($multipart_form_required) {
    250     $replace['admin_form_tag_init'] = "<form enctype=\"multipart/form-data\" method=\"post\" action=\"<\x3fphp echo \$_SERVER['PHP_SELF']; \x3f>\">\n<input type=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"12000000\">";
    251 } else {
    252     $replace['admin_form_tag_init'] = "<form method=\"post\" action=\"<\x3fphp echo \$_SERVER['PHP_SELF']; \x3f>\">";
     250    $replace['admin_form_tag_init'] = "<form enctype=\"multipart/form-data\" method=\"post\" action=\"<\x3fphp echo oTxt(\$_SERVER['PHP_SELF']); \x3f>\">\n<input type=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"12000000\">";
     251} else {
     252    $replace['admin_form_tag_init'] = "<form method=\"post\" action=\"<\x3fphp echo oTxt(\$_SERVER['PHP_SELF']); \x3f>\">";
    253253}
    254254

  • branches/1.1dev/bin/module_maker/skel/adm_list.ihtml

    r109 r185  
    33
    44<div id="commandbox">
    5     <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="get">
     5    <form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="get">
    66        <?php printHiddenSession(false); ?>
    77        <span class="nowrap commandtext"><a href="<?php echo ohref($_SERVER['PHP_SELF'] . '?op=add'); ?>"><?php echo _("Add %ITEM_TITLE%"); ?></a></span>
    … …  
    1818<?php include 'adm_list_info.ihtml'; ?>
    1919
    20 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     20<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    2121    <?php printHiddenSession(false); ?>
    2222    <table class="list">

  • branches/1.1dev/lib/PEdit.inc.php

    r1 r185  
    273273        }
    274274        ?>
    275         <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     275        <form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    276276        <input type="hidden" name="filename" value="<?php echo $this->_filename; ?>" />
    277277        <input type="hidden" name="file_hash" value="<?php echo md5('frog_guts' . $this->_filename); ?>" />

  • branches/1.1dev/templates/adm_admin_form.ihtml

    r1 r185  
    11<?php include 'form_error_header.ihtml'; ?>
    22
    3 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     3<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    44<?php printHiddenSession(); ?>
    55<input type="hidden" name="op" value="<?php echo $frm['new_op']; ?>">

  • branches/1.1dev/templates/adm_admin_list.ihtml

    r30 r185  
    11
    22<?php include 'form_error_header.ihtml'; ?>
    3 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     3<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    44<?php $carry_queries = array('search_query', 'filter_admin_priv'); ?>
    55<?php printHiddenSession(false); ?>

  • branches/1.1dev/templates/adm_log_list.ihtml

    r30 r185  
    11
    22<?php include 'form_error_header.ihtml'; ?>
    3 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     3<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    44<?php printHiddenSession(false); ?>
    55

  • branches/1.1dev/templates/adm_login_form.ihtml

    r1 r185  
    1 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     1<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    22<?php printHiddenSession() ?>
    33<table border="0" cellspacing="0" cellpadding="4">

  • branches/1.1dev/templates/adm_record_lock.ihtml

    r1 r185  
    1 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     1<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    22<?php printHiddenSession() ?>
    33<input type="hidden" name="lock_id" value="<?php echo $lock->getID(); ?>" />

  • branches/1.1dev/templates/adm_record_version_list.ihtml

    r1 r185  
    1 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     1<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    22<?php printHiddenSession() ?>
    33<input type="submit" class="formsubmitbutton" name="op" value="<?php echo _("Cancel"); ?>">

  • branches/1.1dev/templates/login_form.ihtml

    r1 r185  
    1 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     1<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    22<?php printHiddenSession() ?>
    33<table border="0" cellspacing="0" cellpadding="4">

  • branches/1.1dev/templates/passwd.ihtml

    r1 r185  
    11<?php include 'form_error_header.ihtml'; ?>
    22
    3 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     3<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    44<?php printHiddenSession() ?>
    55<input type="hidden" name="op" value="update_password">

  • tags/2.0.2/bin/module_maker/list_template.cli.php

    r111 r185  
    109109
    110110<div id="commandbox">
    111 <form action="<\x3fphp echo \$_SERVER['PHP_SELF']; \x3f>" method="get">
     111<form action="<\x3fphp echo oTxt(\$_SERVER['PHP_SELF']); \x3f>" method="get">
    112112<\x3fphp App::printHiddenSession(false); \x3f>
    113113    <span class="nowrap commandtext"><a href="<\x3fphp echo App::oHREF(\$_SERVER['PHP_SELF'] . '?op=add'); \x3f>"><\x3fphp echo _("Add <##>"); \x3f></a></span>
    … …  
    124124<?php include 'list_info.ihtml'; \x3f>
    125125
    126 <form action="<\x3fphp echo \$_SERVER['PHP_SELF']; \x3f>" method="post">
     126<form action="<\x3fphp echo oTxt(\$_SERVER['PHP_SELF']); \x3f>" method="post">
    127127<table class="list">
    128128    <tr>

  • tags/2.0.2/bin/module_maker/module.cli.php

    r111 r185  
    221221if ($upload_file_capability) {
    222222    // Form arguments
    223     $replace['admin_form_tag_init'] = "<form enctype=\"multipart/form-data\" method=\"post\" action=\"<\x3fphp echo \$_SERVER['PHP_SELF']; \x3f>\" class=\"sc-form\">\n<input type=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"<##>\" />";
     223    $replace['admin_form_tag_init'] = "<form enctype=\"multipart/form-data\" method=\"post\" action=\"<\x3fphp echo oTxt(\$_SERVER['PHP_SELF']); \x3f>\" class=\"sc-form\">\n<input type=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"<##>\" />";
    224224
    225225    // Include statement.

  • tags/2.0.2/bin/module_maker/skel/adm_list.ihtml

    r51 r185  
    33
    44<div id="commandbox">
    5 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="get">
     5<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="get">
    66<?php App::printHiddenSession(false); ?>
    77    <span class="nowrap commandtext"><a href="<?php echo App::oHREF($_SERVER['PHP_SELF'] . '?op=add'); ?>"><?php echo _("Add %ITEM_TITLE%"); ?></a></span>
    … …  
    1616</div>
    1717
    18 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     18<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    1919<?php App::printHiddenSession(); ?>
    2020<?php include 'list_info.ihtml'; ?>

  • tags/2.0.2/lib/PEdit.inc.php

    r101 r185  
    212212        }
    213213        ?>       
    214         <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post" id="sc-pedit-form">
    215         <input type="hidden" name="filename" value="<?php echo $_SERVER['PHP_SELF']; ?>" />
     214        <form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post" id="sc-pedit-form">
     215        <input type="hidden" name="filename" value="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" />
    216216        <input type="hidden" name="file_hash" value="<?php echo $this->_fileHash(); ?>" />
    217217        <?php

  • tags/2.0.2/lib/RecordLock.inc.php

    r111 r185  
    334334    {
    335335        ?>
    336         <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     336        <form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    337337        <?php App::printHiddenSession() ?>
    338338        <input type="hidden" name="lock_id" value="<?php echo $this->getID(); ?>" />

  • tags/2.0.2/services/templates/admin_form.ihtml

    r22 r185  
    11<?php $fv->printErrorMessages(); ?>
    22
    3 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     3<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    44<?php App::printHiddenSession(); ?>
    55<input type="hidden" name="op" value="<?php echo $frm['new_op']; ?>" />

  • tags/2.0.2/services/templates/admin_list.ihtml

    r54 r185  
    11
    22<?php $fv->printErrorMessages(); ?>
    3 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     3<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    44<?php App::printHiddenSession(false); ?>
    55<div id="commandbox">

  • tags/2.0.2/services/templates/lock.ihtml

    r42 r185  
    44}
    55?>
    6 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     6<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    77    <?php App::printHiddenSession() ?>
    88    <input type="hidden" name="lock_id" value="<?php echo $lock->getID(); ?>" />

  • tags/2.0.2/services/templates/log_list.ihtml

    r28 r185  
    1 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     1<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    22<?php App::printHiddenSession(false); ?>
    33

  • tags/2.0.2/services/templates/login_form.ihtml

    r22 r185  
    1 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     1<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    22<?php App::printHiddenSession() ?>
    33<table>

  • tags/2.0.2/services/templates/password.ihtml

    r22 r185  
    11<?php $fv->printErrorMessages(); ?>
    22
    3 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     3<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    44<?php App::printHiddenSession() ?>
    55<input type="hidden" name="op" value="update_password" />

  • tags/2.0.2/services/templates/versions_list.ihtml

    r49 r185  
    1 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     1<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    22<?php App::printHiddenSession() ?>
    33<input type="submit" name="op" value="<?php echo _("Cancel"); ?>" />

  • trunk/bin/module_maker/list_template.cli.php

    r154 r185  
    109109
    110110<div id="commandbox">
    111 <form action="<\x3fphp echo \$_SERVER['PHP_SELF']; \x3f>" method="get">
     111<form action="<\x3fphp echo oTxt(\$_SERVER['PHP_SELF']); \x3f>" method="get">
    112112<\x3fphp \$app->printHiddenSession(false); \x3f>
    113113    <span class="sc-nowrap commandtext"><a href="<\x3fphp echo \$app->oHREF(\$_SERVER['PHP_SELF'] . '?op=add'); \x3f>"><\x3fphp echo _("Add __///__"); \x3f></a></span>
    … …  
    124124<?php include 'list_info.ihtml'; \x3f>
    125125
    126 <form action="<\x3fphp echo \$_SERVER['PHP_SELF']; \x3f>" method="post">
     126<form action="<\x3fphp echo oTxt(\$_SERVER['PHP_SELF']); \x3f>" method="post">
    127127<table class="list">
    128128    <tr>

  • trunk/bin/module_maker/module.cli.php

    r154 r185  
    223223if ($upload_file_capability) {
    224224    // Form arguments
    225     $replace['admin_form_tag_init'] = "<form enctype=\"multipart/form-data\" method=\"post\" action=\"<\x3fphp echo \$_SERVER['PHP_SELF']; \x3f>\" class=\"sc-form\">\n<input type=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"__///__\" />";
     225    $replace['admin_form_tag_init'] = "<form enctype=\"multipart/form-data\" method=\"post\" action=\"<\x3fphp echo oTxt(\$_SERVER['PHP_SELF']); \x3f>\" class=\"sc-form\">\n<input type=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"__///__\" />";
    226226
    227227    // Include statement.

  • trunk/bin/module_maker/skel/adm_list.ihtml

    r154 r185  
    33
    44<div id="commandbox">
    5 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="get">
     5<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="get">
    66<?php $app->printHiddenSession(false); ?>
    77    <span class="sc-nowrap commandtext"><a href="<?php echo $app->oHREF($_SERVER['PHP_SELF'] . '?op=add'); ?>"><?php echo _("Add %ITEM_TITLE%"); ?></a></span>
    … …  
    1616</div>
    1717
    18 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     18<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    1919<?php $app->printHiddenSession(); ?>
    2020<?php include 'list_info.ihtml'; ?>

  • trunk/lib/Lock.inc.php

    r149 r185  
    365365
    366366        ?>
    367         <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     367        <form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    368368        <?php $app->printHiddenSession() ?>
    369369        <input type="hidden" name="lock_id" value="<?php echo $this->getID(); ?>" />

  • trunk/lib/Navigation.inc.php

    r184 r185  
    1818    // Configuration parameters for this object.
    1919    var $_params = array(       
    20         'html_title' = true,
    21         'body_title' = true,
     20        'head_title' => true,
     21        'body_title' => true,
    2222        'title' => true,
    2323        'path' => true,
    … …  
    5858        $page = array(
    5959            'title' => $title,
    60             'url' => is_null($url) ? $_SERVER['PHP_SELF'] : $url;
     60            'url' => is_null($url) ? $_SERVER['PHP_SELF'] : $url,
    6161        );
    6262        $this->pages[] = array_merge($page, $vars);

  • trunk/lib/PEdit.inc.php

    r146 r185  
    228228        }
    229229        ?>       
    230         <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post" id="sc-pedit-form">
    231         <input type="hidden" name="filename" value="<?php echo $_SERVER['PHP_SELF']; ?>" />
     230        <form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post" id="sc-pedit-form">
     231        <input type="hidden" name="filename" value="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" />
    232232        <input type="hidden" name="file_hash" value="<?php echo $this->_fileHash(); ?>" />
    233233        <?php

  • trunk/services/templates/admin_form.ihtml

    r136 r185  
    11<?php $fv->printErrorMessages(); ?>
    22
    3 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     3<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    44<?php $app->printHiddenSession(); ?>
    55<input type="hidden" name="op" value="<?php echo $frm['new_op']; ?>" />

  • trunk/services/templates/admin_list.ihtml

    r136 r185  
    11
    22<?php $fv->printErrorMessages(); ?>
    3 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     3<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    44<?php $app->printHiddenSession(false); ?>
    55<div id="commandbox">

  • trunk/services/templates/lock.ihtml

    r141 r185  
    44}
    55?>
    6 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     6<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    77    <?php $app->printHiddenSession() ?>
    88    <input type="hidden" name="lock_id" value="<?php echo $lock->getID(); ?>" />

  • trunk/services/templates/log_list.ihtml

    r153 r185  
    1 <form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
     1<form action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>" method="post">
    22<?php $app->printHiddenSession(false); ?>
    33

  • trunk/services/templates/login_form.ihtml

    r136 r185  
    1 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     1<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    22<?php $app->printHiddenSession() ?>
    33<table>

  • trunk/services/templates/password.ihtml

    r136 r185  
    11<?php $fv->printErrorMessages(); ?>
    22
    3 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     3<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    44<?php $app->printHiddenSession() ?>
    55<input type="hidden" name="op" value="update_password" />

  • trunk/services/templates/versions_list.ihtml

    r136 r185  
    1 <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
     1<form method="post" action="<?php echo oTxt($_SERVER['PHP_SELF']); ?>">
    22<?php $app->printHiddenSession() ?>
    33<input type="submit" name="op" value="<?php echo _("Cancel"); ?>" />
Note: See TracChangeset for help on using the changeset viewer.